Skip to content
Snippets Groups Projects
Commit de5bbfc6 authored by Dmitry Frolov's avatar Dmitry Frolov Committed by Michael Tokarev
Browse files

hw/cxl: Fix out of bound array access


According to cxl_interleave_ways_enc(), fw->num_targets is allowed to be up
to 16. This also corresponds to CXL r3.0 spec. So, the fw->target_hbs[]
array is iterated from 0 to 15. But it is statically declared of length 8.
Thus, out of bound array access may occur.

Fixes: c28db9e0 ("hw/pci-bridge: Make PCIe and CXL PXB Devices inherit from TYPE_PXB_DEV")
Signed-off-by: default avatarDmitry Frolov <frolov@swemel.ru>
Reviewed-by: default avatarMichael Tokarev <mjt@tls.msk.ru>
Link: https://lore.kernel.org/r/20230913101055.754709-1-frolov@swemel.ru


Cc: qemu-stable@nongnu.org
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: default avatarMichael Tokarev <mjt@tls.msk.ru>
parent 6ff35919
Branches
No related tags found
No related merge requests found
......@@ -29,7 +29,7 @@ typedef struct PXBCXLDev PXBCXLDev;
typedef struct CXLFixedWindow {
uint64_t size;
char **targets;
PXBCXLDev *target_hbs[8];
PXBCXLDev *target_hbs[16];
uint8_t num_targets;
uint8_t enc_int_ways;
uint8_t enc_int_gran;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment